Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect computation of wavelets #5

Open
daniel-unyi-42 opened this issue Jun 14, 2020 · 0 comments
Open

Incorrect computation of wavelets #5

daniel-unyi-42 opened this issue Jun 14, 2020 · 0 comments

Comments

@daniel-unyi-42
Copy link

First of all, thank you for sharing your code, it was extremely useful for my project.

I believe the function 'weight_wavelet_inverse' does not work as intended.
Since you alter the eigenvalues in 'weight_wavelet' permanently,
in 'weight_wavelet_inverse' you compute the exponential on the altered eigenvalues (basically you do an exp of exp thing).
The product of the wavelet and its inverse should always be identity.

Funny enough, your half-incorrect code gives better results than the corrrect one.
I guess it's because other kernels can perform better than the heat kernel?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant