Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rule] Allow maximum per kill AA amount #4329

Merged
merged 4 commits into from
May 25, 2024
Merged

[Rule] Allow maximum per kill AA amount #4329

merged 4 commits into from
May 25, 2024

Conversation

fryguy503
Copy link
Contributor

Description

Allow you to clamp the maximum per kill aa amount awarded.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Testing

Set AA xp to 0 for each kill.

Before Clamping:
image

After Clamping:

image
image

Clients tested:

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

Kinglykrab
Kinglykrab reviewed May 25, 2024
View reviewed changes
common/ruletypes.h Outdated Show resolved Hide resolved
Kinglykrab
Kinglykrab reviewed May 25, 2024
View reviewed changes
zone/exp.cpp Outdated Show resolved Hide resolved
@Kinglykrab Kinglykrab merged commit c56742a into master May 25, 2024
2 checks passed
@Kinglykrab Kinglykrab deleted the trust/MaxAAXpPerKill branch May 25, 2024 21:48
@Akkadius Akkadius mentioned this pull request May 26, 2024
Merged
catapultam-habeo pushed a commit to The-Heroes-Journey-EQEMU/Server that referenced this pull request Jul 14, 2024
@fryguy503 @Kinglykrab @catapultam-habeo
[Rule] Allow maximum per kill AA amount (EQEmu#4329)
6a5eda6 
* [Rule] Allow maximum per kill AA amount

* Adjustments per comments

* Finalize.

* Update ruletypes.h

---------

Co-authored-by: Kinglykrab <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kinglykrab Kinglykrab Kinglykrab approved these changes

Assignees

@Kinglykrab Kinglykrab

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fryguy503 @Kinglykrab