Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Fix issue with #hotfix #4316

Merged
merged 1 commit into from
May 22, 2024
Merged

[Bug Fix] Fix issue with #hotfix #4316

merged 1 commit into from
May 22, 2024

Conversation

Kinglykrab
Copy link
Contributor

Description

  • Fixes issue where VariablesRepository::GetWhere was using name instead of varname for the column name in its query.
  • Mentioned here by Celtic Trinity Studios.

Type of Change

  • Bug fix

Testing

image

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Akkadius
Copy link
Member

image
image

My testing, lgtm.

@Akkadius Akkadius merged commit ca69cc6 into master May 22, 2024
2 checks passed
@Akkadius Akkadius deleted the bug_fix/hotfix branch May 22, 2024 20:38
@Akkadius Akkadius mentioned this pull request May 26, 2024
catapultam-habeo pushed a commit to The-Heroes-Journey-EQEMU/Server that referenced this pull request Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants