Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Commands] Adjust #kill and #list Commands #4271

Merged
merged 2 commits into from
May 4, 2024

Conversation

Kinglykrab
Copy link
Contributor

@Kinglykrab Kinglykrab commented Apr 19, 2024

Description

  • Adds the ability to use #kill with a supplied entity ID, i.e. #kill 123.
  • Adds bot support to the #list command and adds #kill saylinks to the #list data if the client can use the #kill command.

Type of Change

  • New feature (non-breaking change which adds functionality)

Testing

image
image

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Kinglykrab Kinglykrab changed the title [Commands] Adjust #kill/#list Commands [Commands] Adjust #kill and #list Commands Apr 19, 2024
@noudess
Copy link
Contributor

noudess commented Apr 19, 2024

I'm not looking for a change in this PR, but I think in the future we should split changes. 1 PR for enhancing #kill for entity IDs and another for adding bot support. The more singular we make PRs, the easier it is to review quickly, as well as rollback 1 change while leaving the other.

@Akkadius
Copy link
Member

I'm not looking for a change in this PR, but I think in the future we should split changes. 1 PR for enhancing #kill for entity IDs and another for adding bot support. The more singular we make PRs, the easier it is to review quickly, as well as rollback 1 change while leaving the other.

Agreed

Copy link
Member

@Akkadius Akkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your test images show NPCss so we're getting double plurality due to some of the changes you made

@Kinglykrab
Copy link
Contributor Author

Your test images show NPCss so we're getting double plurality due to some of the changes you made

Resolved.

@Akkadius Akkadius merged commit 943274b into master May 4, 2024
2 checks passed
@Akkadius Akkadius deleted the commands/kill_list_adjust branch May 4, 2024 22:49
@Akkadius Akkadius mentioned this pull request May 9, 2024
catapultam-habeo pushed a commit to The-Heroes-Journey-EQEMU/Server that referenced this pull request Jul 14, 2024
* [Commands] Adjust #kill/#list Commands

* Update list.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants