[Spells] Implemented SPA 122 SE_ReduceSkill #4234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SE_ReduceSkill SPA 122 base: skill id, limit: none, max: none, formula: % skill is reduced (positive)
Kinglykrab
reviewed
Apr 1, 2024
remove incorrect SPA addition
Akkadius
reviewed
Apr 15, 2024
Akkadius
reviewed
Apr 21, 2024
Kinglykrab
reviewed
Apr 24, 2024
Comment on lines
+12415
to
+12417
| if (itembonuses.skillmodmax[skill_id] > 0){ | ||
|
|
||
| if (itembonuses.skillmodmax[skill_id] > 0) { |
There was a problem hiding this comment.
These are the same conditions, is this intentional or copy and paste error?
Akkadius
approved these changes
May 4, 2024
Akkadius
added a commit
that referenced
this pull request
May 5, 2024
Merged
catapultam-habeo
pushed a commit
to The-Heroes-Journey-EQEMU/Server
that referenced
this pull request
Jul 14, 2024
* Implement SPA122 v1 * Implemented SPA 122 ReduceSkill SE_ReduceSkill SPA 122 base: skill id, limit: none, max: none, formula: % skill is reduced (positive) * Implemented SPA 122 Reduce Skill remove incorrect SPA addition * Break out multiple lines * reformatted reformatted --------- Co-authored-by: Akkadius <[email protected]>
catapultam-habeo
pushed a commit
to The-Heroes-Journey-EQEMU/Server
that referenced
this pull request
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented SPA 122 - ReduceSkill
This spell effect acts as a debuff that reduces a clients skill value by percentage.
Example Live spell Curse of 1H Blunt (39667) "Decrease 1H Blunt Skill by 45%"
Base value: Skill ID, Limit: none, Max: none, Formula value = % reduction
For above example. Base=0 (1H Blunt skill id), Formula = 45
So if your 1H Blunt skills is 200, and you apply a 45% debuff you now have a 1H Blunt skill of 110 for the duration of the debuff.
The client GetSkill function I know looks a bit ugly, but I coded it in a way to be consistent with the current format and use the least amount of additional checks/calculations, since we do check this very often in the code. Essentially it just adds one check if you have the debuff, then will do all calculations to account for that, otherwise it just checks skills in the way it did before.