Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Radiant/Ebon Crystals should only extract to 1000 #4195

Merged
merged 2 commits into from
Mar 23, 2024

Conversation

fryguy503
Copy link
Contributor

Creating a stack larger than 1000 can cause potential dupe issues further down the stream if other tasks are performed on the stack.

Creating a stack larger than 1000 can cause potential dupe issues further down the stream if other tasks are performed on the stack.
Copy link
Contributor

@joligario joligario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think RoF(2) allows up to 1K. I think Tit peaks at 20? Thinking we could test and limit per client?

@Kinglykrab
Copy link
Contributor

Kinglykrab commented Mar 22, 2024

I think RoF(2) allows up to 1K. I think Tit peaks at 20? Thinking we could test and limit per client?

Are we sure that Titanium doesn't stack to 1,000? I don't have it to test.

@Kinglykrab Kinglykrab changed the title [Bug] Radiant/Ebon Crystals should only extract to 1000 [Bug Fix] Radiant/Ebon Crystals should only extract to 1000 Mar 22, 2024
@joligario
Copy link
Contributor

Hence thinking we need to test. I have titanium and I will check tonight.

@fryguy503
Copy link
Contributor Author

fwiw

Live | 2007-03-22 14:00 | Changed stacksize from '1000' to '232'

@Kinglykrab
Copy link
Contributor

Confirmed on Titanium we can stack up to 1,000. Decided to use the item's stacksize instead if the item is stackable, if not we default to a max of 1 reclaimed at a time. We clamp a stackable item's reclaim amount between 1 and 1,000, even if the stacksize goes beyond 1,000.

@joligario
Copy link
Contributor

Perfect! I like that much better. I can test later if you haven't already.

@Kinglykrab
Copy link
Contributor

I have not tested this yet.

@Akkadius
Copy link
Member

Pending testing it looks like

@joligario
Copy link
Contributor

Looks like Titanium can handle 1K charges.

image

@Akkadius Akkadius merged commit d2372de into master Mar 23, 2024
2 checks passed
@Akkadius Akkadius deleted the bug/crystal_max branch March 23, 2024 17:57
MortimerGreenwald pushed a commit to MortimerGreenwald/Server that referenced this pull request Apr 15, 2024
* [Bug] Radiant/Ebon Crystals should only extract to 1000

Creating a stack larger than 1000 can cause potential dupe issues further down the stream if other tasks are performed on the stack.

* Use stacksize instead

---------

Co-authored-by: Kinglykrab <[email protected]>
MortimerGreenwald pushed a commit to MortimerGreenwald/Server that referenced this pull request Apr 15, 2024
* [Bug] Radiant/Ebon Crystals should only extract to 1000

Creating a stack larger than 1000 can cause potential dupe issues further down the stream if other tasks are performed on the stack.

* Use stacksize instead

---------

Co-authored-by: Kinglykrab <[email protected]>
@Akkadius Akkadius mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants