StyleXmlHelper bug

[shishu123cn]

StyleXmlHelper.cs
line 37 internal int newID = int.MinValue;

Why is int.minvalue set here?

It may cause xfsid to be negative after save。

ExcelStyle.cs
line 60 Numberformat = new ExcelNumberFormat(styles, ChangedEvent, PositionID, Address, _xfs.NumberFormatId);
_xfs maybe null。

[shishu123cn]

#486
One of my previous problems finally reproduced this bug

[JanKallman]

Can you please provide some code to reproduce your issue. Please also provide a workbook if necessary.

[shishu123cn]

<cellStyleXfs count="3"><xf numFmtId="0" fontId="0" fillId="0" borderId="0" /><xf numFmtId="0" fontId="0" fillId="0" borderId="0" /><xf numFmtId="0" fontId="2" fillId="0" borderId="0" /></cellStyleXfs>

styles.xml is like this,

ExcelStyles.cs :
private void LoadFromDocument()
{
..................................

        //cellStyleXfs
        XmlNode styleXfsNode = GetNode(CellStyleXfsPath);
        if (styleXfsNode != null)
        {
            foreach (XmlNode n in styleXfsNode)
            {
                ExcelXfs item = new ExcelXfs(_nameSpaceManager, n, this);
                CellStyleXfs.Add(item.Id, item);
            }
        }

}

ExcelXfsXml.cs ：
XfId = GetXmlNodeInt("@Xfid");

When there is no @Xfid field, the default value of int.MinValue will be used, which will cause a series of problems later

[shishu123cn]

XmlHelper.cs:
internal int GetXmlNodeInt(string path, int defaultValue=int.MinValue)

DefaultValue here

[JanKallman]

This is just fragments of code. I can not reproduce the issue from this. Please provide full code and a workbook that I can test this with.

[shishu123cn]

I am a company network and cannot provide you with a workbook。

[shishu123cn]

You can directly modify Xfid to int.MinValue, then open and save the workbook, this problem should occur

[shishu123cn]

Why is the default value here set to int.MinValue
internal int GetXmlNodeInt(string path, int defaultValue=int.MinValue)

[JanKallman]

This is beyond the support we provide here. If you have a commercial license please provide your workbook inside our support portal.

[shishu123cn]

We are a small tool for internal use, not for commercial use

[JanKallman]

If you are a commercial company you still need a license for internal use.

[shishu123cn]

Ok i got it