New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decimals where unnecessary #1105

Open

OssianEPPlus opened this issue Oct 16, 2023 · 0 comments

Labels

Contributor

OssianEPPlus commented Oct 16, 2023

Multiple areas in Epplus use Decimal rather than double for no apparent reason even when excel uses doubles. A few examples are:

ExcelChartTrendline.cs
which uses it for many properties: Order, Period, Forward, Backward, Intercept
ExcelDoughnutChart.cs
that uses it in FirstSliceAngle, HoleSize
ExcelTime.cs
which uses it everywhere.
ExcelWorkbook.cs
Which uses it for MaxFontWidth
ExcelView3D
for perspective and rotation
ExcelPrinterSettings
for margins
FontSize
height and width
ExcelSparklineColor and ExcelColorXml
uses it for Tint.

Most or all of these would match excel and have less overhead if we used double instead as we do most other places in epplus.

OssianEPPlus added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment