Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move unit test to test folder #622

Closed
wants to merge 1 commit into from
Closed

move unit test to test folder #622

wants to merge 1 commit into from

Conversation

a25max
Copy link
Contributor

@a25max a25max commented Jan 26, 2020

Issue

Overview (Required)

  • I want to fix for cant recognize library in class of jvmTest folder. Unit test class move to test/java folder.

Links

No

Screenshot

No

@jmatsu-bot
Copy link
Collaborator

Your apk has been deployed to https://deploygate.com/distributions/5ea9658a5704d8287ac9ee5239256d2f1d6bd9dc. Anyone can try your changes via the link.

Generated by 🚫 Danger

@jmatsu-bot
Copy link
Collaborator

2 Errors
🚫 Tests have failed, see below for more information.
🚫 At least one test case failed

Tests:

Name Classname Time
isPass_forSpeechSession[empty filter passes beginners session] io.github.droidkaigi.confsched2020.model.FiltersTest$WhenSpeechSessionIsChecked 0.004
isPass_forSpeechSession[empty filter passes non beginners session] io.github.droidkaigi.confsched2020.model.FiltersTest$WhenSpeechSessionIsChecked 0.001
isPass_forSpeechSession[Beginners filter passes beginners session] io.github.droidkaigi.confsched2020.model.FiltersTest$WhenSpeechSessionIsChecked 0.001
isPass_forSpeechSession[Beginners filter does not pass non beginners session] io.github.droidkaigi.confsched2020.model.FiltersTest$WhenSpeechSessionIsChecked 0.0
isPass_forSpeechSession[Unspecified filter does not pass beginners session] io.github.droidkaigi.confsched2020.model.FiltersTest$WhenSpeechSessionIsChecked 0.0
isPass_forSpeechSession[Unspecified filter passes non beginners session] io.github.droidkaigi.confsched2020.model.FiltersTest$WhenSpeechSessionIsChecked 0.0
isPass_forSpeechSession[filter has Beginners and Unspecified passes beginners session] io.github.droidkaigi.confsched2020.model.FiltersTest$WhenSpeechSessionIsChecked 0.001
isPass_forSpeechSession[filter has Beginners and Unspecified passes non beginners session] io.github.droidkaigi.confsched2020.model.FiltersTest$WhenSpeechSessionIsChecked 0.0

Generated by 🚫 Danger

@takahirom
Copy link
Member

Does that tests failed? 👀

@a25max
Copy link
Contributor Author

a25max commented Jan 27, 2020

Yes, I can't understand this test so I may resolve this test more time.

@a25max
Copy link
Contributor Author

a25max commented Jan 27, 2020 •
edited
Loading

I think I should mod Filters class. add about audienceCategories.

@a25max
Copy link
Contributor Author

a25max commented Jan 28, 2020

Sorry, give up 😭

@roana0229
Copy link
Contributor

No worries. 😄
Thank you for your challenge 👍
Could you please close this PR ?

@a25max
Copy link
Contributor Author

a25max commented Jan 29, 2020

OK, I see. Thank you 🙏

@a25max a25max closed this Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

a few files in jvmTest are not recognize dependency libraries.
4 participants
@a25max @jmatsu-bot @takahirom @roana0229