Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename search screen classes #496

Open
FujiKinaga opened this issue Jan 21, 2020 · 4 comments
Open

Rename search screen classes #496

FujiKinaga opened this issue Jan 21, 2020 · 4 comments
Assignees
@mkw8263
Labels
easy welcome contribute

Comments

@FujiKinaga
Copy link
Contributor

FujiKinaga commented Jan 21, 2020 •
edited
Loading

Kind (Required)

  • Improvement

Overview (Required)

  • Currently it's named as SearchSessions. But we are also able to search speakers in this screen.
    • Please rename SearchSessions to Search in all files.
  • It must be born a lot of conflicts so should not contribute yet😅
@mkw8263
Copy link

mkw8263 commented Jan 21, 2020

I want to try :)

@FujiKinaga
Copy link
Contributor Author

@mkw8263
Thanks! Assigned 👍
I think that this pr will ready when #437 is merged.
So I throw a mention at you when you're ready to work with welcome contribution label😄

@FujiKinaga
Copy link
Contributor Author

@mkw8263
Hi.
I am sorry for contacting you late😭
You may work before waiting for merge #437.
Please let me know if you have any questions and troubles🙏

@mkw8263
Copy link

mkw8263 commented Feb 3, 2020 •
edited
Loading

@FujiKinaga
Hello 👍
It is interesting.
I'll work on it right away :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkw8263 mkw8263

Labels
easy welcome contribute
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkw8263 @FujiKinaga