-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding 40 languages to custom list failed in admin area #2417
Comments
We'll want to update this to be a ajax post requestwith the changes instead of a php post. |
Files to update:
The _POST for adding a language contains the whole form and the updates for translations on each language: Once ~1000 fields is reached, some hosts trim the _POST request. Todo:
How we've fixed it in the past: |
@corsacca @squigglybob I am still working on implementing an ajax solution, but may have found a way to cut down on the huge requests in the mean time: https://www.loom.com/share/fa2486ca60cd486db30907dba3bdb88b?sid=38186f73-51ec-464b-aad1-1f148628d71c |
I think that's not a bad idea as it will make any POSTs more efficient when the translations aren't being used. You can see where the translations get used by navigating to /settings and scrolling down to the section "Languages you are comfortable speaking" The translations will show up here. We have to assume the worst (best?) case, of these sections being fully translated. So while stripping out the empty translations will reduce POST size when they aren't there, the system still needs to be able to cope when the array is full of translations. |
I think adding that last commit finishes this @corsacca. Unless I'm missing something. |
@corsacca Trying to add 40 languages for zume to the languages list on wp-admin/admin.php?page=dt_options&tab=custom-lists
failed at around 18
The text was updated successfully, but these errors were encountered: