Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments: like, favorite or react to a comment. #537

Closed
corsacca opened this issue May 22, 2018 · 6 comments · Fixed by #1255
Closed

Comments: like, favorite or react to a comment. #537

corsacca opened this issue May 22, 2018 · 6 comments · Fixed by #1255
Assignees
@squigglybob
Labels
add mockup Identifies issues that would benefit from a mockup feature New features or functionality help wanted
Projects
Groups and Contacts Features

Comments

@corsacca
Copy link
Member

corsacca commented May 22, 2018 •
edited
Loading

Purpose: Add clarity and usability to the comments area.

Benefits:

  • Reactions will visually show that a user has seen the comment without having to write a whole reply.
  • Reactions will allow the user to quickly scan the comments to find the most importand ones.
  • Reactions will improve communication by allowing users to easily respond to any comment.

Requirements:
The user can react to any comment on a record.
The user can choose between 6 options of reaction.
If a comment has reactions they will be displayed under the comment. Each reaction icon with a number associated to it.
If the user hovers over (or clicks on for mobile) the reaction icon, it will show a list of users who reacted.
Default reaction options (same as Facebook): thumbs up, heart, laugh, wow, sad face, angry
Customization: add filters to allow for a plugin to add or remove from the list.

Code considerations:
Start with dt-assests/js/comments.js, dt-assets/parts/loop-activity-comment.php, dt-posts/dt-posts.php and dt-posts/dt-posts-endpoins.php
Reactions will likely be stored in the comment meta. This feature will need to extend the existing comment functions to include getting meta data.
@corsacca corsacca added the feature New features or functionality label May 22, 2018
@corsacca corsacca added this to To Do in Groups and Contacts via automation May 22, 2018
@corsacca corsacca added this to To do in Features May 11, 2019
@corsacca corsacca moved this from To do to Requested By Several in Features May 11, 2019
@corsacca corsacca added the add mockup Identifies issues that would benefit from a mockup label Aug 20, 2019
@micahmills micahmills mentioned this issue May 12, 2020
Open
@mikeallbutt
Copy link
Contributor

A simple system like what GitHub uses would help.

Screenshot 2020-07-14 13 16 22

@squigglybob
Copy link
Collaborator

How would users un-react to a comment? If clicking on the reaction shows the users who have reacted, should picking the same reaction again, unreact it? In github, clicking the reaction unreacts it, and hovering shows the users... :O/

@squigglybob
Copy link
Collaborator

also where best to put the reaction dropdown button? underneath the comment? or to the right of the comment?

@corsacca
Copy link
Member Author

Good questions @squigglybob ,
Here is a guess, tho i'm up for it being improved:

  • click on a reaction to "un-react"
  • show the reaction under the comment
  • I don't know where the reaction dropdown best fits. Actions that appear when you hover of the text make sense, but won't work on mobile.

@squigglybob
Copy link
Collaborator

Yup, that's what I'm thinking, I can either put the dropdown button underneath
image
or to the left
image

@squigglybob squigglybob mentioned this issue Mar 26, 2021
Merged
@corsacca
Copy link
Member Author

I think underneath next to edit and delete (when they are present) will work the best.
An icon with a plus on it like on slack would be nice.
I didn't see a good one on https://thenounproject.com/ where a lot of our icons have come from

Groups and Contacts automation moved this from To Do to Done Apr 20, 2021
Features automation moved this from Requested By Several to Done Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@squigglybob squigglybob

Labels
add mockup Identifies issues that would benefit from a mockup feature New features or functionality help wanted
Projects
Features
  
Done
Groups and Contacts
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

537 react to comments squigglybob/disciple-tools-theme
3 participants
@squigglybob @corsacca @mikeallbutt