Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Ensure only fully tested pushes and only correctly tagged releases #136

Merged
merged 1 commit into from
Oct 20, 2019

Conversation

luczsoma
Copy link
Member

On git push, everything is tested. On npm publish, the package version
is matched with the released revision's tag to avoid accidental
releases.

Closes #135.

Pull Request Checklist

Please check if your PR fulfills the following requirements:

  • The pull request consists of exactly one commit.
  • The commit message follows the commit message guidelines.
  • Tests for the changes have been added / updated (for features / bug fixes).
  • Docs have been added / updated (for features / bug fixes).

Pull Request Type

What kind of change does this pull request introduce?

  • Feature
  • Bugfix
  • Code styling update
  • Refactoring / performance improvement (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Testing related changes
  • Housekeeping (e.g. dependency updates)
  • Reverting a previous change

What is the current behavior? Which issue does this PR close?

Issue reference: #135

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@luczsoma luczsoma self-assigned this Oct 20, 2019
@auto-badge auto-badge bot added the ci Made the code better by enhancing the flow of merging/deploying additional code label Oct 20, 2019
On git push, everything is tested. On npm publish, the package version
is matched with the released revision's tag to avoid accidental
releases.

Closes #135.
@luczsoma luczsoma force-pushed the ci/ensure-tested-pushes-and-release-tags branch from 7da2354 to 3ca3e4a Compare October 20, 2019 20:51
@luczsoma luczsoma merged commit 0acf3de into develop Oct 20, 2019
@luczsoma luczsoma deleted the ci/ensure-tested-pushes-and-release-tags branch October 20, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Made the code better by enhancing the flow of merging/deploying additional code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure that only fully-tested commits can be pushed & only tagged revs can be published
1 participant