feat: Remove default Node.js support #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luczsoma
force-pushed
the
feat/no-node-js
branch
from
21a21e1
to
8423e88
Compare
luczsoma
force-pushed
the
feat/no-node-js
branch
3 times, most recently
from
2785e66
to
d301bdd
Compare
BREAKING CHANGE: Default Node.js support is removed. It is hard to use different APIs in different environments right in today's bundled world. Closes #116.
luczsoma
force-pushed
the
feat/no-node-js
branch
from
d301bdd
to
bc21feb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Default Node.js support is removed. It is hard to use
different APIs in different environments right in today's bundled world.
Closes #116.
Pull Request Checklist
Please check if your PR fulfills the following requirements:
Pull Request Type
What kind of change does this pull request introduce?
What is the current behavior? Which issue does this PR close?
Issue reference: #116
What is the new behavior?
In Node.js environment, the module will not work, unless the user injects a Node-based entropy provider instance, which has every step written down in the README.md
Does this PR introduce a breaking change?
This PR contains a breaking change. If you used
crypto-randomis a Node.js environment, you will need to copy-paste some code from the README.md file specifically prepared for this scenario. It will take about 15 minutes.Other information
–