Code refactoring for jquery efficiency and organization #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"let" is preferred in ES6 because it forces block scope instead of function scope. It can prevent some confusing bugs as a result. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/let#Block_scope_with_let
misc fixes
# Conflicts: # src/js/components/story.js # src/js/components/task.js # src/js/components/team.js # src/js/components/teampicker.js
# Conflicts: # src/nodejs/app.js
# Conflicts: # src/js/components/teampicker.js
# Conflicts: # src/js/components/board.js # src/js/components/editStoryModal.js # src/js/components/story.js # src/nodejs/app.js
-reverting arrow function to anonymous function so "this" will properly refer to mocha -increasing test timeout so wdio, selenium, and the browser can connect
-Beginning to properly set up test context
-Placing webdriverio config options "baseUrl" into the right spot and adding "logLevel" -Adding "logLevel" to config file
-Manually entering changes from David's commit here: DiZy@e7f19a3?diff=unified
…two different files. This is more in line with express 4, and it allows tests to start their own server with a test database, or run unit/integration tests against the app itself, independent of the server.
…to resolve the merge conflict with the main repo
…to resolve the merge conflict with the main repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://24ways.org/2011/your-jquery-now-with-less-suck/