Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Bug]: Button组件问题 #55

Open
xingyan95 opened this issue Dec 22, 2021 · 1 comment
Open

🐛 [Bug]: Button组件问题 #55

xingyan95 opened this issue Dec 22, 2021 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@xingyan95
Copy link
Member

xingyan95 commented Dec 22, 2021

Version

v1.0.0-beta.12

Vue Version

3.1.1

Link to minimal reproduction

https://vue-devui.github.io/components/button/

Step to reproduce

  1. button组件鼠标移上显示"手势",好像没有在组件内部设置,而是通过网站的button标签设置后生效的。
    image

  2. successwarning类型的按钮,文字颜色是黑色。
    image

  3. 事件应该是通过emit触发的吧?通过props传入回调函数有点奇怪呢? 而且,事件名字是不是叫click更好些呢?
    image

What is expected

  1. 鼠标移上显示“手势”,在组件内部设置。
  2. successwarning类型的按钮,文字颜色应该是白色。

What is actually happening

No response

Any additional comments (optional)

No response

@kagol kagol added the good first issue Good for newcomers label Dec 22, 2021
@Zcating
Copy link
Collaborator

Zcating commented Dec 23, 2021

问题1:button 标签本身自带 cursor: pointer,所以当时也没想那么多。
问题2:该类型的文本颜色以及hover后的颜色,需要 kagol 与 devui 的设计师团队沟通讨论后得出。
问题3:vue3 的事件触发机制有两种,emit 和 function prop,在模板中, @click 等价于 onClick。通过 props 传入回调参数没什么奇怪的,ng,React 都是这样设计,Vue 当然也可以。

@kagol kagol added this to the v1.0.0 milestone Mar 18, 2022
@kagol kagol added the bug Something isn't working label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants