Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: DeniseWorthen/CICE Loading
base: 1046c608d4bc18d64476d9ae88423f2633992686
Choose a base ref
...
head repository: DeniseWorthen/CICE Loading
compare: 91fe75fa2586160a7cf568bd2e59c604325d8f17
Choose a head ref
  • 6 commits
  • 117 files changed
  • 3 contributors

Commits on Aug 12, 2022

  1. ice_grid: do call 'gridbox_verts' for rectangular grids (CICE-Consort…

    …ium#749)
    
    At the end of subroutine ice_grid::gridbox_corners, the arrays
    'lont_bounds' and 'lonu_bounds', which contain the longitude of the
    corners of each grid cell on the T and U grids, are converted to to the
    [0, 360] range.
    
    In the case of rectangular grids ('grid_type = rectangular'), at the
    point where 'gridbox_corners' is called in 'init_grid2', 'lont_bounds'
    is not initialized, causing the code to abort if compiling with NaN
    initialization. This is due to the fact that 'gridbox_verts', which
    initializes 'lont_bounds' and 'latt_bounds', is not called in
    'rectgrid', whereas it is called in 'popgrid[_nc]'.
    
    Do call 'gridbox_verts' in 'rectgrid', so that 'lont_bounds' and
    'latt_bounds' are correctly initalized in that case also.
    
    Note that these calls are also missing in 'latlongrid' and 'cpomgrid',
    but since these two subroutines are not used in standalone
    configuration, let's not bother for now.
    phil-blain committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    08c6b33 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. Clean up code and add several minor features (CICE-Consortium#750)

    * Update/improve debug_blocks output, see CICE-Consortium#718.
    
    * Add ICE_MEMUSE cice.settings flag for batch memory use
    Add set_env.memsmall, memmed, memlarge options
    To use, will require changes to the env machine files.  Most machines will probably not use it.
    See CICE-Consortium#674.
    
    * Add setup_machparams.csh to compute batch/launch machine parameters
    Update cice.batch.csh and cice.launch.csh to use setup_machparams.csh
    See CICE-Consortium#650
    
    * Update subroutine diagnostic_abort which calls print_state
    Update ice_transport_remap and ice_transport_driver to call diagnostic_abort
      during some errors.
    See also CICE-Consortium#622
    
    * Update miniconda install information
    See CICE-Consortium#547
    
    * Code cleanup based on compile with -Wall
    Code cleanup based on -std f2003 and f2008 checks
    Add -stand f08 to cheyenne_intel debug flags
    Add -std f2008 to cheyenne_gnu debug flags
    Code consistent with Fortran 2003 except for use of contiguous in
      1d evp code.
    
    * Remove all trailing blank space with script
    
    * Update the cheyenne env so qc testing works
    Add configuration/scripts/tests/qctest.yml file
    Update documentation
    
    * Update Icepack
    
    * Clean up some output
    
    * fix comments
    
    * update print_state output
    apcraig committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    d673e44 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. Update ECCC machine files (CICE-Consortium#751)

    * machines: eccc: unify baseline directory
    
    * machines: eccc: fix modules initialization
    
    Make sure to source the Csh initialization script for environment
    modules ourselves, as it is not done in all environments.
    
    While at it, for convenience add I_MPI_LIBRARY_KIND=debug to the
    commented lines.
    phil-blain committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    75ef5d2 View commit details
    Browse the repository at this point in the history
  2. ice_calendar: zero-initialize 'nstreams' (CICE-Consortium#752)

    The variable ice_calendar::nstreams, which corresponds to the number of
    output history streams to use for the run, is initialized in
    ice_history::init_hist depending on the number of non-'x' elements in
    'histfreq' in the namelist.
    
    However, the code does use 'nstreams' before ice_history::init_hist is
    called, in ice_calendar::calendar when called from
    ice_calendar::init_calendar. Both 'init_calendar' and 'init_hist' are
    called from CICE_InitMod::cice_init, in that order, such that the loop
    that initializes 'write_history' in 'calendar' uses 'nstreams'
    uninitialized.
    
    'calendar' ends up being called at least once more during 'cice_init', from
    ice_calendar::advance_timestep, at which point 'nstreams' is correctly
    defined and 'write_history' is thus correctly initialized, before its
    first use in 'accum_hist'.
    
    To avoid using 'nstreams' uninitialized in the first call to 'calendar'
    from 'init_calendar', initialize it to zero in 'init_calendar' before
    calling 'calendar'.
    
    This issue was discovered by compiling using the '-init=huge' flag of
    the Intel compiler.
    phil-blain committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    fea412a View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2022

  1. Configuration menu
    Copy the full SHA
    df29da7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    91fe75f View commit details
    Browse the repository at this point in the history
Loading