Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Count moved columns as fresh activity #297

Closed
wants to merge 4 commits into from

Conversation

jablko
Copy link
Contributor

@jablko jablko commented Dec 30, 2020

Adds moved columns events to lastActivityDate.

Also don't close PRs before moving them to "Needs Author Action", which then generates fresh activity and triggers the usual timelines.

Fixes #306

src/queries/pr-query.ts Outdated Show resolved Hide resolved
@jablko jablko force-pushed the patch-53 branch 3 times, most recently from 066ff81 to 752696c Compare January 3, 2021 23:50
@jablko jablko changed the title Count review requests as fresh activity Count moved columns as fresh activity Jan 3, 2021
@jablko jablko force-pushed the patch-53 branch 2 times, most recently from 0037601 to c893dd0 Compare January 4, 2021 01:05
@elibarzilay
Copy link
Contributor

I don't think that this is a good idea.

On one hand, when maintainers move a column to indicate a "blessing",
the idea was to have no implications of this other than just the
blessing. This changes that simplicity into a "blessing and
potentially reset the staleness timeline if it's based on last
activity" -- complicated enough that nobody would remember it.

On the other hand, you're not ignoring bot column changes, which I first
thought was an ommision, but then I saw that you're relying on that in
the second commit. The main design decision that I like about this bot
(and is not due to me) is the fact that it's idempotent: it doesn't rely
on some external database or on adding meta-information as a "current
state" thing to be used later on. For example, we can run the bot at
any time and it won't lead to any changes (and this is a fact that is
was useful several times now: there's a periodic scan that runs it on
all PRs without worrying about leading to broken behavior, and to avoid
race conditions with multiple instances the a PR processing can be
canceled if a new trigger for the same PR arrived). It's something that
I did my best to not break -- and the one very minor exception is the
code that looks for a merge offer to determine if a merge request is
valid.

In any case, this breaks that in a more substantial way. It can lead to
bogus behavior (for example, if the column changes when a PR is inactive
for a while, the next iteration would see the change as activity and
change the column again). This might not be a problem now, but it can
lead to such problems with future changes, so I really don't want to do
it...

@orta
Copy link
Contributor

orta commented Jan 13, 2021

I'm with Eli, lets drop this one - thanks @jablko

@orta orta closed this Jan 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants