Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/Update Navbar Image #142

Closed
10 tasks done
GaspardMathon opened this issue Dec 16, 2022 · 3 comments
Closed
10 tasks done

Improve/Update Navbar Image #142

GaspardMathon opened this issue Dec 16, 2022 · 3 comments
Assignees
Labels
android 🟒 Related to android enhancement πŸš€ New feature or request

Comments

@GaspardMathon
Copy link
Member

GaspardMathon commented Dec 16, 2022

Duplicates ❌

  • I have searched the existing issues

Which Figma library is concerned?

Vitamin Android UI Kit

Summary πŸ’‘

For now, there is a section in the documentation of the Navbar on Android that states that it is possible to add a background image on the Navbar :
image

Doc Decathlon Design

For accessibility purposes, it may be important to change this doc, whether to raise awareness of accessibility issues that could bring this or simply remove this possibility to avoid contrast problems. (Or add a disclaimer to explain the possible problems with the image)

Dependencies πŸ“¦

None

Examples 🌈

No response

Motivation πŸ”¦

Make our interfaces the most accessible possible ;)

New πŸ†•

  • Validated in a grooming session

Backlog πŸ“‹

  • Has a good summary
  • Has example link(s)

Design in progress πŸ—

  • Analysis (functional & technical)
  • Design refinement
  • Dev qualification (properties, breakpoints, tokens etc.)
  • Documentation refinement (inside the Figma branch)

Design review πŸ‘€

  • Figma branch merged
  • Documentation review _(and move the documentation into Vitamin Documentation Figma file)
@GaspardMathon GaspardMathon added the enhancement πŸš€ New feature or request label Dec 16, 2022
@Sabrinavigil
Copy link
Contributor

Add a transparent top app bar

@lauthieb
Copy link
Member

lauthieb commented Jan 19, 2023

Add a transparent top app bar

After grooming session:

  • @Decathlon/design-system-core-team-design needs to check regarding accessibility standards (because not in Material)
  • @ManonPolle needs to check if this could be possible on vitamin-android

@Sabrinavigil
Copy link
Contributor

with button background

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android 🟒 Related to android enhancement πŸš€ New feature or request
Projects
Archived in project
Development

No branches or pull requests

5 participants