Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod Disruption Budget isn't created for cluster agent #864

Open
ylee-figma opened this issue Jul 25, 2023 · 2 comments
Open

Pod Disruption Budget isn't created for cluster agent #864

ylee-figma opened this issue Jul 25, 2023 · 2 comments

Comments

@ylee-figma
Copy link

Output of the info page (if this is a bug)

❯ k get datadogagents.datadoghq.com
NAME      AGENT             CLUSTER-AGENT     CLUSTER-CHECKS-RUNNER   AGE
datadog   Running (4/4/4)   Running (2/2/2)                           76d

❯ k get pdb -A | rg cluster

Describe what happened:
If the replica count is above 1, then PDB should be created according to this logic:

if dda.Spec.ClusterAgent.Replicas != nil && *dda.Spec.ClusterAgent.Replicas > 1 {

However, maybe because the apiVersion changed on the agent, it's not creating PDBs.

Describe what you expected:
PDB for cluster agent to be created

Steps to reproduce the issue:
Scale up replica of cluster agent to 2.

Additional environment details (Operating System, Cloud provider, etc):

@levan-m
Copy link
Contributor

levan-m commented Jul 25, 2023

Hello,

Thanks for submitting the issue! You are right 0.8.x managed PDB for both Cluster Agent and Cluster Checks Runners, this isn't yet supported in 1.x.x, fact highlighted here. We haven't prioritized this for the upcoming 1.1.0, we may be able to do it for the next one.

@jalaziz
Copy link

jalaziz commented Oct 25, 2023

Coming from the helm chart installation method, I noticed this was missing too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants