Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLO burn rate #1022

Open
melchiormoulin opened this issue Dec 20, 2023 · 4 comments
Open

SLO burn rate #1022

melchiormoulin opened this issue Dec 20, 2023 · 4 comments

Comments

@melchiormoulin
Copy link

Hello, since there a customressource to define SLO #807
How can we define burn rate alert based on this SLO CR ?
It seems there is some internal discussions ( this comment #807 (comment) )

@vlinevych
Copy link

vlinevych commented Dec 20, 2023

I've found an example of slo alert, but the problem is that it requires slo-hash-id in the query.

For burn rate alert the query would be something like this:

query: "burn_rate(\"slo-hash-id\").over(\"30d\").long_window(\"1h\").short_window(\"5m\") > 14.4"

It would be great to have slo burn rate alert implemented in the operator.

@melchiormoulin
Copy link
Author

Hello do you think there is any chance to see this feature please @fanny-jiang @ddjamesfrullo ? :)

@jurabek
Copy link
Contributor

jurabek commented Mar 25, 2024

There is possibility to create CRD only for burn rate and pass those values as attributes instead of hard-coded string query: "burn_rate(\"slo-hash-id\").over(\"30d\").long_window(\"1h\").short_window(\"5m\") > 14.4" value, and this gives us referencing parent SLO into this alert more natively, k8s operator does provide such functionality I will try work on that, in my free time.

@melchiormoulin
Copy link
Author

melchiormoulin commented Jun 12, 2024

Hey do you think it can be implemented ? Maybe @jurabek ?
It would be super nice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants