Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dogstatsd] better use of the counter and gauges in the string interner #20420

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

remeh
Copy link
Contributor

@remeh remeh commented Oct 26, 2023

What does this PR do?

Improves how #20308 is using the internal telemetry to improve performances. We remarked a performance hit in that area with our nightly benchmarks.

Additional Notes

Added a basic micro-benchmark to validate performance improvements.

Before:

BenchmarkLoadOrStoreReset-10             1335985               900.7 ns/op

After:

BenchmarkLoadOrStoreReset-10            12263616               93.39 ns/op

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@remeh remeh added component/dogstatsd changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card team/agent-metrics-logs labels Oct 26, 2023
@remeh remeh added this to the 7.50.0 milestone Oct 26, 2023
@remeh remeh requested a review from a team as a code owner October 26, 2023 08:52
@remeh remeh merged commit 0dd4109 into main Oct 26, 2023
144 checks passed
@remeh remeh deleted the remeh/si-tlm branch October 26, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants