Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wsi.py #26

Merged
merged 4 commits into from
Oct 27, 2020
Merged

Update wsi.py #26

merged 4 commits into from
Oct 27, 2020

Conversation

Karenxzr
Copy link
Collaborator

Recalculated chunk number when stride size is small to avoid black edges. When pad=Flase, all tiles are in size of (size,size,3) without any black edges. When pad=True, the edge chunks will be padded with black edges by openslide.

Recalculated chunk number when stride size is small to avoid black edges. When pad=Flase, all tiles are in size of (size,size,3) without any black edges. When pad=True, the edge chunks will be padded with black edges by openslide.
@jacob-rosenthal
Copy link
Collaborator

Good catch. I didn't know that openslide would do zero padding automatically!
Can you file an issue that this pull request would close?
And also add test cases that fail currently which would pass with this change?

@jacob-rosenthal jacob-rosenthal merged commit 175dda3 into master Oct 27, 2020
@jacob-rosenthal jacob-rosenthal deleted the Karenxzr-wsi branch October 27, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants