-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DoctrineSubscriber throw deprecation when Driver is wrapped with another class #184
Comments
related also to #185 |
@oleg-andreyev is this issue still relevant? |
@DamienHarper Relevant for 2.x |
@oleg-andreyev could you please share a way (code sample) so I can reproduce the issue? |
you'll need # composer.json
"sentry/sentry-symfony": "^4.6",
"damienharper/auditor-bundle": "^5.0", # sentry.yaml
sentry:
dsn: '%env(SENTRY_DSN)%'
options:
traces_sample_rate: 0.25
# Set a sampling rate for profiling - this is relative to traces_sample_rate
profiles_sample_rate: 1.0
before_send: 'sentry.callback.before_send'
register_error_listener: false # Disables the ErrorListener to avoid duplicated log in sentry
monolog:
handlers:
sentry:
type: sentry
level: !php/const Monolog\Logger::ERROR
hub_id: Sentry\State\HubInterface
basically any wrapper will break it because current assumption that DHDriver is the last one. |
@oleg-andreyev thanks |
@DamienHarper any progress here? We are experiencing this problem in our project also (Sym6.4+sentry/[email protected]) @oleg-andreyev were you able to resolve somehow? |
@craigh planning to work on solution |
@craigh @DamienHarper added my PR #195 |
Thanks @oleg-andreyev for the PR, much appreciated. It's currently merged into |
Closed as merged |
auditor
versionSummary
I have both Auditor and Sentry packages.
Sentry also has a middleware that wraps connection with a special class.
Depending on priority of this middlewares
DoctrineSubscriber
may trigger a deprecation because $driver is not aDHDriver
, but actually it's wrapped.Current behavior
trigger deprecation when it's actually should not
How to reproduce
Install both damienharper/auditor-bundle and sentry/sentry-symfony
Expected behavior
correct detection of
DHDriver
The text was updated successfully, but these errors were encountered: