Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential performance Issue: Slow read_csv() Function with pandas 1.3.3 #70

Open
TendouArisu opened this issue Mar 2, 2024 · 3 comments

Comments

@TendouArisu
Copy link

Issue Description:

Hello.
I have discovered a performance degradation in the read_csv function of pandas version 1.3.3. And I notice some parts of the repository depend on pandas 1.3.3 in dadmatools/requirements.txt and some other dependencies require pandas below 1.4. I am not sure whether this performance problem in pandas will affect this repository. I found some discussions on pandas GitHub related to this issue, including #44158 and #44610.
I also found that dadmatools/pipeline/informal2formal/utils.py and dadmatools/pipeline/informal2formal/VerbHandler.py used the influenced api. There may be more files using the influenced api.

Suggestion

I would recommend considering an upgrade to a different version of pandas >= 1.4 or exploring other solutions to optimize the performance of read_csv.
Any other workarounds or solutions would be greatly appreciated.
Thank you!

@sadeghjafari5528
Copy link
Collaborator

Thank you for your comment; I will try to update the Pandas version. However, I'm uncertain whether our "informal2formal" function utilized the influenced API.

On another note, I wanted to inquire if you have knowledge about the Persian language?

@TendouArisu
Copy link
Author

No, I don't know the Persian language. I encountered this problem in other repositories, so I wanted to note other repositories this potential problem.

@sadeghjafari5528
Copy link
Collaborator

Thank you for your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants