Use enum for vendor id #165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy behaviour of e. g. `free` and `fftw_plan_destroy`, where deleting null pointer does nothing instead of segmentation fault.
Add NULL pointer check to deleteVkFFT
…real transform per axis (as uint) -Solves DTolm#151
-Allows to change descriptors inside one command buffer -Needs to be enabled by the user before vkCreateDevice and set with usePushDescriptors flag in configuration of VkFFT -there is a warning in validation layer that needs to be investigated "vkCreateDevice: pCreateInfo->pNext chain includes a structure with unexpected VkStructureType VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PUSH_DESCRIPTOR_PROPERTIES_KHR"
-improved glslang management in CMake -replaced the relative path to the glslang_c_interface with the full path
-enabled through singleKernelMultipleBatches parameter -kernel batching is controlled through coordinateFeatures -number of input/output systems is controlled through numberBatches -sample 53 shows the usage of this option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces
VkFFTVendorenum datatype for vendor id instead of using magic values. It is based on the same datatype asstreamIDmember was.