Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible path error when applying custom-blender-path on windows #970

Closed
Gitlifer opened this issue Aug 26, 2023 · 3 comments · Fixed by #972
Closed

Possible path error when applying custom-blender-path on windows #970

Gitlifer opened this issue Aug 26, 2023 · 3 comments · Fixed by #972
Labels
bug_on_windows

Comments

@Gitlifer
Copy link

Describe your feature request

In blenderproc/python/utility/InstallUtility.py,

        # Run script
        if platform in ["linux", "linux2"]:
            blender_run_path = os.path.join(blender_path, "blender")
        elif platform == "darwin":
            blender_run_path = os.path.join(blender_path, "Contents", "MacOS", "Blender")
        elif platform == "win32":
            blender_run_path = os.path.join(blender_install_path, blender_version, "blender")
        else:
            raise RuntimeError(f"This system is not supported yet: {platform}")

If custom_blender_path is provided in command line, there are some issues:

  1. blender_install_path will be initialized incorrectly if it is not specified
  2. blender_version is not defined
  3. "blender" may lead to path error ( -> "blender.exe")

Describe a possible solution

No response
@Gitlifer Gitlifer added the enhancement New feature or request label Aug 26, 2023
@Bear-kai
Copy link

Bear-kai commented Aug 29, 2023 •
edited
Loading

I found it too and chose an alternative way to solve it.
If you already have blender (v3.3.1) installed on your machine. Ensure that the installed folder is like:

D:\Programs\blender-3.3.1-windows-x64\blender-3.3.1-windows-x64

Note that "D:\Programs" can be replaced by your path. Then, run script like this:

blenderproc quickstart --blender-install-path=D:\Programs

You can set the path as the param's default value in command_line.py to avoid specify it each time. The location of this script depends on your env. For me, it is

D:\Programs\miniconda3\envs\pose\Lib\site-packages\blenderproc\command_line.py

@cornerfarmer cornerfarmer mentioned this issue Aug 31, 2023
Merged
@cornerfarmer
Copy link
Member

Thanks for letting us now.
Could you check whether #972 solves your issue?

@cornerfarmer cornerfarmer added bug_on_windows and removed enhancement New feature or request labels Aug 31, 2023
@cornerfarmer
Copy link
Member

I assume this means yes, the changes are now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug_on_windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(windows): Fixes usage of custom blender path on windows DLR-RM/BlenderProc
3 participants
@Bear-kai @cornerfarmer @Gitlifer