Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jordansissel/xdotool Loading
base: master
Choose a base ref
...
head repository: Cycatz/xdotool Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Oct 17, 2022

  1. xdo_search: fix improper memfrees, pre-compile regexes optimization 

    Original author: Peter Wu <[email protected]>
Modified by: Cycatz <[email protected]>

If any of compile_re statements fails, all uninitialized regex_t objects
are freed due to short-circuit evaluation, which causing segmentation faults.
Now they are initialized to zero with memset and besides that,
all regexes are now pre-compiled before iterating through all windows.

(as a side-effect of the optimization: return early when a regex fails
to compile).

Other changes: constantify regex_t* where applicable.
    @Cycatz
    Cycatz committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    d4d7fee View commit details
    Browse the repository at this point in the history
Loading