Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Add Content-Encoding to file before uploading, possible? #151

Open
anaxyd opened this issue Nov 22, 2015 · 2 comments
Open

Question: Add Content-Encoding to file before uploading, possible? #151

anaxyd opened this issue Nov 22, 2015 · 2 comments

Comments

@anaxyd
Copy link

anaxyd commented Nov 22, 2015

I am thinking of using your great plugin for uploading some big .json files to Amazon S3. These are to be used with Three.js, and can often be 20MB +. Therefore I need to gzip compress these so save a lot of space.

But Amazon S3 needs to know the Content-Encoding header for the file that is compressed as gzip, so I wonder if its possible to set this in your plugin before uploading?

@anaxyd
Copy link
Author

anaxyd commented Nov 28, 2015

Nobody knows?

@gsuess
Copy link
Contributor

gsuess commented Nov 30, 2015

Sorry for late reply. As it is now, slingshot doesn't support that attribute yet. But it could easily be added here https://github.com/CulturalMe/meteor-slingshot/blob/master/services/aws-s3.js#L6 and then here: https://github.com/CulturalMe/meteor-slingshot/blob/master/services/aws-s3.js#L153

Please try to make pull request. I will process them over the winter period and them make sure content-encoding is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants