From 74275105c43fdbbf0b8796d304895f3ab7519e6b Mon Sep 17 00:00:00 2001 From: Rahul Tarak Date: Sat, 15 Jan 2022 04:50:15 +0530 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Fix=20npm=20run=20bug?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- installer/package.json | 2 +- internal/commands/dts.go | 2 +- internal/utils/packageManger.go | 10 +++++++++- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/installer/package.json b/installer/package.json index 0f527b2..54455b3 100644 --- a/installer/package.json +++ b/installer/package.json @@ -1,6 +1,6 @@ { "name": "tsdev-installer", - "version": "0.0.17", + "version": "0.0.18", "description": "The installer for tsdev, a better tsdx", "scripts": { "postinstall": "node dist/postinstall.js install", diff --git a/internal/commands/dts.go b/internal/commands/dts.go index be03b00..360cd24 100644 --- a/internal/commands/dts.go +++ b/internal/commands/dts.go @@ -27,7 +27,7 @@ func EmitDts(cwd string, name string) error { } } fmt.Println("Package manager is ", packageJson.TSDEV.PackageManager) - err = utils.ExecWithOutput(cwd, utils.GetPackageManager(packageJson.TSDEV.PackageManager), "tsc", "--outDir", "dist/src/") + err = utils.ExecWithOutput(cwd, utils.GetPackageManager(packageJson.TSDEV.PackageManager, true), "tsc", "--outDir", "dist/src/") if err != nil { buildWg.Done() return err diff --git a/internal/utils/packageManger.go b/internal/utils/packageManger.go index 7a2736b..b828f83 100644 --- a/internal/utils/packageManger.go +++ b/internal/utils/packageManger.go @@ -2,7 +2,7 @@ package utils import "internal/types" -func GetPackageManager(packageManger types.PackageManagerType) string { +func GetPackageManager(packageManger types.PackageManagerType, run bool) string { switch packageManger { case types.Pnpm: @@ -15,10 +15,18 @@ func GetPackageManager(packageManger types.PackageManagerType) string { } case types.Npm: { + // npm run cannot run node modules, the way yarn or pnpm can + if run { + return "yarn" + } return "npm" } default: { + // npm run cannot run node modules, the way yarn or pnpm can + if run { + return "yarn" + } return "npm" } }