Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extracting svgs does not auto set his extension name #251

Closed
Mrgaton opened this issue Jun 19, 2024 · 4 comments · Fixed by #258
Closed

Extracting svgs does not auto set his extension name #251

Mrgaton opened this issue Jun 19, 2024 · 4 comments · Fixed by #258
Labels
feature

Comments

@Mrgaton
Copy link

Mrgaton commented Jun 19, 2024

When extracting the game files, the SVGs are saved as files without an extension when they should automatically be assigned the .svg extension.
@Mrgaton
Copy link
Author

Mrgaton commented Jun 19, 2024

image

@Crauzer
Copy link
Owner

Crauzer commented Jun 19, 2024

How would you identify that a file is a valid SVG document ?
There is no way to sensibly do this

@Mrgaton
Copy link
Author

Mrgaton commented Jun 19, 2024

read the first 4 bytes of the file and see if starts with <svg

@Crauzer
Copy link
Owner

Crauzer commented Jun 19, 2024

mb lol im dumb

@Crauzer Crauzer mentioned this issue Jun 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add svg detection Crauzer/Obsidian
2 participants
@Crauzer @Mrgaton