-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back resource_exists
validator for uri
field on File
#52
Labels
Projects
Comments
Based on FireO's implementation, I don't think it's possible to pass in kwargs to a validator method passed in. Two things we could do are:
I think 2 would be the easier option and give us more options to customize to our use cases in the future. |
I added an option to pass kwargs to validator functions in this PR, so this should be doable now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We had to remove the usage of
resources_exists
from the uri field validator because we couldn't think of a method to pass the google credentials to the validator. At some point we may want to add this back but this shouldn't hold up #49 from being merged.Originally posted by @isaacna in #49 (comment)
The text was updated successfully, but these errors were encountered: