feature/hash-file-contents #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 98.60% 98.63% +0.03%
==========================================
Files 42 42
Lines 1291 1321 +30
==========================================
+ Hits 1273 1303 +30
Misses 18 18
Continue to review full report at Codecov.
|
isaacna
reviewed
Jun 6, 2021
Comment on lines
+93
to
+94
| video_uri: str | ||
| The uri to the video file to split audio from. |
There was a problem hiding this comment.
Thanks for adding the documentation here, I must've forgot this earlier
isaacna
approved these changes
Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request recommendations:
Resolves #51
Hashes the file content in buffer chunk reads to protect against massive files. Additionally updates the pipeline a tiny bit to handle this change.
We should download the file once instead of hashing the file remotely then downloading for audio splitting.
So now it is:
I also updated the deps and fixed the one test that broke because of dep changes.
I also ran
make run-min-event-pipelineto test as well.... Which I am somewhat tempted to add as CI here. 🤷 we will see, log below:Here is the new pipeline DAG:
Thanks for contributing!