Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt fireo transactional for upload safety #44

Closed
evamaxfield opened this issue Jan 19, 2021 · 2 comments
Closed

Adopt fireo transactional for upload safety #44

evamaxfield opened this issue Jan 19, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed low priority Doesn't need immediate attention
Projects

Comments

@evamaxfield
Copy link
Member

Use Case

Please provide a use case to help us understand your request in context

Further ensure that no "bad" or "incomplete" data is uploaded to a CDP database.

Solution

Please describe your ideal solution

Rework the event gather pipeline to create the fireo models from the ingestion models but do not upload until the very end of the pipeline where we can upload all of them in a single fireo transaction.

Alternatives

Please describe any alternatives you've considered, even if you've dismissed them

@evamaxfield evamaxfield added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed low priority Doesn't need immediate attention labels Jan 19, 2021
@evamaxfield
Copy link
Member Author

evamaxfield commented Jan 19, 2021

Fleshing this out a little more:

I don't think we can build a transaction throughout the flow for multiple reasons

  1. I don't think a multi function transaction is possible with the fireo API
  2. I don't know if fireo models are serializable and all prefect / parallel things need to be pickleable

So it would more so be: do all the processing that we need to do up front and then have one large upload task at the end that is itself a large transaction

@sarahjliu sarahjliu added this to Backlog in v3.0 Jul 10, 2021
@evamaxfield
Copy link
Member Author

Closing for now. We can revisit at a later point but many of our database models rely on each other and it would be hard to upload an event. We would have to do it in multiple transcactions if we wanted to at.

v3.0 automation moved this from Backlog to Done Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed low priority Doesn't need immediate attention
Projects
No open projects
v3.0
Done
Development

No branches or pull requests

1 participant