admin/adopy-mypy-type-checking #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 98.67% 98.68% +0.01%
==========================================
Files 17 17
Lines 454 458 +4
==========================================
+ Hits 448 452 +4
Misses 6 6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
🍹 The Update (preview) for stack CouncilDataProjectServiceAccount/cdp-infrastructure/cdp-example was successful.
Resource Changes
Name Type Operation
+ cdp-example-firestore-app gcp:appengine/application:Application create
+ matter_file-matter_ref_ASCENDING_name_ASCENDING gcp:firestore/index:Index create
+ matter_status-matter_ref_ASCENDING_update_datetime_ASCENDING gcp:firestore/index:Index create
+ cdp-example-firestore-service gcp:projects/service:Service create
+ cdp-example-compute-service gcp:projects/service:Service create
+ transcript-session_ref_ASCENDING_created_DESCENDING gcp:firestore/index:Index create
+ event-body_ref_ASCENDING_event_datetime_ASCENDING gcp:firestore/index:Index create
+ event-body_ref_ASCENDING_event_datetime_DESCENDING gcp:firestore/index:Index create
+ matter_status-matter_ref_ASCENDING_update_datetime_DESCENDING gcp:firestore/index:Index create
+ event_minutes_item-event_ref_ASCENDING_index_ASCENDING gcp:firestore/index:Index create
+ event_minutes_item_file-event_minutes_item_ref_ASCENDING_name_ASCENDING gcp:firestore/index:Index create
+ transcript-session_ref_ASCENDING_confidence_DESCENDING gcp:firestore/index:Index create
+ cdp-infrastructure-cdp-example pulumi:pulumi:Stack create
+ cdp-example CDPStack create
+ cdp-example-speech-service gcp:projects/service:Service create
+ event_minutes_item-event_ref_ASCENDING_index_DESCENDING gcp:firestore/index:Index create
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request recommendations:
Resolves #18
Adopts MyPy for type checking. While sometimes annoying, in the long run a good move to maintain the repo across multiple devs + PRs and such.
Note:
There are some changes in here that relate to mypy type checking, notably, the one that threw me off was mypy will try to use the same typing over the same variable at it's first initialization. Example:
mypywill complain because I initializedsome_stringasList[str]but then later used it as astr. This should basically just teach me to use better naming conventions.Thanks for contributing!