bugfix/clean-pictograms-from-transcripts-before-indexing #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #165 +/- ##
==========================================
- Coverage 94.56% 94.49% -0.08%
==========================================
Files 50 50
Lines 2558 2560 +2
==========================================
Hits 2419 2419
- Misses 139 141 +2
Continue to review full report at Codecov.
|
isaacna
approved these changes
Feb 17, 2022
I think this transcript is from a converted closed caption. Which makes a bit more sense 😂 |
evamaxfield
deleted the
bugfix/clean-pictograms-from-transcripts-before-indexing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Relevant Issue
This pull request resolves #151
Description of Changes
Include a description of the proposed changes.
Finally found time to fix this one. Can't believe the bug either.
Looks like a transcript from Seattle has a
♪pictogram / emoticon in it...link -- start at 30:09 -- or search for
♪This fixes the pipeline by adding a function to clean all common pictograms / emojis from the sentence before stemming and fuzzy matching for context spans.
Tested by running the pipeline and storing the index locally:
run_cdp_event_index -n 1 --store_local --parallel ../configs-and-special-events/seattle.json