-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate minimal event data and minimal session data over from cdptools #10
Comments
Note to self, will also be adding an |
Adding more examples, I am not sure this is 100% accurate but I think you get the idea: constants.VoteDecisions.Approved = "approved"
constants.VoteDecisions.Rejected = "rejected"
# etc
Vote(NamedTuple):
person: str # this could even be further to a person named tuple but idk
decision: str
...
EventMinutesItem(NamedTuple):
votes: Optional[List[Vote]]
matter: Optional[Matter]
...
EventData(NamedTuple):
...
event_minutes_items: Optional[List[EventMinutesItem]] I think you see what I am building at. This is basically just taking the database models all together and stacking them in an order / structure that is relevant to a single event. In which it may be best to not make this is End goal however is to have a single object of |
Now that I think about it, using the existing But if we want to output a single EventData object, we'll need to store We could do something like typing With this would it make more sense to create separate ingestion objects apart from the |
Yea that's a good catch. I think it just makes sense to define a bunch of Also note we can add / check / validate a bunch of the ingestion data based off of just primary keys where as the fireo models are "full objects" i.e. a |
Use Case
Please provide a use case to help us understand your request in context
Standardize and version the acceptable data format we accept for pipelines with the pipeline code itself rather than scrapper side.
Solution
Please describe your ideal solution
Migrate the work done by @isaacna on cdptools to this repo.
Potentially change the name from
MinimalEventData
andMinimalSessionData
to justEventData
andSessionData
as I think with theOptional
keys, they are the full event data spec.We should also make objects for
VoteData
and such, which are a part of theOptional[List[MinutesItems]]
. Basically the entire data structure of all minimal data and optional data should be documented as the accepted data structure we accept for pipelines.Notes
This unfortunately will require a bit of copying the database ORM definitions unless we can think of a way to programmatically construct all of these models. I.E. run through the DB ORM definitions and created NamedTuples of every single model with the appropriate
Optional
tags. I think it's possible.The text was updated successfully, but these errors were encountered: