-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect MAVEN_USER_HOME in MavenUtil #637
Comments
Originally it was an issue with tests being run and creating |
That is correct, I am currently busy with v3. In fact, there's a heavy rewrite going underway. But with that in mind, outline all your needs and I'll see what I can do about addressing them in v3. For awareness, v3 is going to be bumping the minimum version of Java required to run Recaf, most likely to 17. The plan is to have a launcher module for users not using a package manager, and then publish the necessary files for repository maintainers to keep their own mechanisms for keeping up-to-date without the launcher.
👍 Looks like a fine solution. |
Hello! I am the maintainer of AUR packages for your software. I'm unsure if version 2 is still being maintained or you're occupied by work on v3, however, I have encountered a problem when packaging a VCS package for AUR.
The issue is about
MavenUtil
class which uses a hardcoded path for Maven local repository, which may be affected byMAVEN_USER_HOME
or other Maven settings:Recaf/src/main/java/me/coley/recaf/util/MavenUtil.java
Lines 168 to 173 in ca07fc0
In my AUR package I resorted to use of the following patch:
I think it wouldn't harm to also account for environment variable or Maven settings, if possible, instead of using hardcoded path. Thank you.
The text was updated successfully, but these errors were encountered: