Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inspector: Added basic support for inspector #470

Merged
merged 9 commits into from
Apr 18, 2022
Merged

Inspector: Added basic support for inspector #470

merged 9 commits into from
Apr 18, 2022

Conversation

nanashili
Copy link
Contributor

@nanashili nanashili commented Apr 17, 2022 •
edited
Loading

Description

Added basic support for the inspector sidebar

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested

Screenshots

Screenshot 2022-04-18 at 16 49 57
Screenshot 2022-04-18 at 16 50 17

@nanashili nanashili changed the title [WIP] Inspector: Added basic support for inspector Inspector: Added basic support for inspector Apr 18, 2022
@nanashili nanashili marked this pull request as ready for review April 18, 2022 14:51
0xWDG
0xWDG approved these changes Apr 18, 2022
View reviewed changes
Copy link
Collaborator

@0xWDG 0xWDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work 😊

@austincondiff austincondiff merged commit 2fa420d into CodeEditApp:main Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austincondiff austincondiff austincondiff approved these changes

@0xWDG 0xWDG 0xWDG approved these changes

@lukepistrol lukepistrol Awaiting requested review from lukepistrol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nanashili @austincondiff @0xWDG