diff --git a/Userland/Shell/AST.cpp b/Userland/Shell/AST.cpp index f069b2c5a789c4..1a294925419ca4 100644 --- a/Userland/Shell/AST.cpp +++ b/Userland/Shell/AST.cpp @@ -408,10 +408,6 @@ Vector Node::complete_for_editor(Shell& shell, size_ return Node::complete_for_editor(shell, offset, { nullptr, nullptr, nullptr }); } -Node::~Node() -{ -} - void And::dump(int level) const { Node::dump(level); @@ -463,10 +459,6 @@ And::And(Position position, NonnullRefPtr left, NonnullRefPtr right, set_is_syntax_error(m_right->syntax_error_node()); } -And::~And() -{ -} - void ListConcatenate::dump(int level) const { Node::dump(level); @@ -580,10 +572,6 @@ ListConcatenate::ListConcatenate(Position position, Vector> } } -ListConcatenate::~ListConcatenate() -{ -} - void Background::dump(int level) const { Node::dump(level); @@ -617,10 +605,6 @@ Background::Background(Position position, NonnullRefPtr command) set_is_syntax_error(m_command->syntax_error_node()); } -Background::~Background() -{ -} - void BarewordLiteral::dump(int level) const { Node::dump(level); @@ -673,10 +657,6 @@ BarewordLiteral::BarewordLiteral(Position position, String text) { } -BarewordLiteral::~BarewordLiteral() -{ -} - void BraceExpansion::dump(int level) const { Node::dump(level); @@ -732,10 +712,6 @@ BraceExpansion::BraceExpansion(Position position, NonnullRefPtrVector entr } } -BraceExpansion::~BraceExpansion() -{ -} - void CastToCommand::dump(int level) const { Node::dump(level); @@ -799,10 +775,6 @@ CastToCommand::CastToCommand(Position position, NonnullRefPtr inner) set_is_syntax_error(m_inner->syntax_error_node()); } -CastToCommand::~CastToCommand() -{ -} - void CastToList::dump(int level) const { Node::dump(level); @@ -865,10 +837,6 @@ CastToList::CastToList(Position position, RefPtr inner) set_is_syntax_error(m_inner->syntax_error_node()); } -CastToList::~CastToList() -{ -} - void CloseFdRedirection::dump(int level) const { Node::dump(level); diff --git a/Userland/Shell/AST.h b/Userland/Shell/AST.h index eea365db0afe26..7e9abeec8fc623 100644 --- a/Userland/Shell/AST.h +++ b/Userland/Shell/AST.h @@ -420,7 +420,7 @@ class Node : public RefCounted { } virtual String class_name() const { return "Node"; } Node(Position); - virtual ~Node(); + virtual ~Node() = default; virtual bool is_bareword() const { return false; } virtual bool is_command() const { return false; } @@ -531,7 +531,7 @@ class PathRedirectionNode : public Node { class And final : public Node { public: And(Position, NonnullRefPtr, NonnullRefPtr, Position and_position); - virtual ~And(); + virtual ~And() = default; virtual void visit(NodeVisitor& visitor) override { visitor.visit(this); } const NonnullRefPtr& left() const { return m_left; } @@ -553,7 +553,7 @@ class And final : public Node { class ListConcatenate final : public Node { public: ListConcatenate(Position, Vector>); - virtual ~ListConcatenate(); + virtual ~ListConcatenate() = default; virtual void visit(NodeVisitor& visitor) override { visitor.visit(this); } const Vector> list() const { return m_list; } @@ -573,7 +573,7 @@ class ListConcatenate final : public Node { class Background final : public Node { public: Background(Position, NonnullRefPtr); - virtual ~Background(); + virtual ~Background() = default; virtual void visit(NodeVisitor& visitor) override { visitor.visit(this); } const NonnullRefPtr& command() const { return m_command; } @@ -591,7 +591,7 @@ class Background final : public Node { class BarewordLiteral final : public Node { public: BarewordLiteral(Position, String); - virtual ~BarewordLiteral(); + virtual ~BarewordLiteral() = default; virtual void visit(NodeVisitor& visitor) override { visitor.visit(this); } const String& text() const { return m_text; } @@ -610,7 +610,7 @@ class BarewordLiteral final : public Node { class BraceExpansion final : public Node { public: BraceExpansion(Position, NonnullRefPtrVector); - virtual ~BraceExpansion(); + virtual ~BraceExpansion() = default; virtual void visit(NodeVisitor& visitor) override { visitor.visit(this); } const NonnullRefPtrVector& entries() const { return m_entries; } @@ -628,7 +628,7 @@ class BraceExpansion final : public Node { class CastToCommand final : public Node { public: CastToCommand(Position, NonnullRefPtr); - virtual ~CastToCommand(); + virtual ~CastToCommand() = default; virtual void visit(NodeVisitor& visitor) override { visitor.visit(this); } const NonnullRefPtr& inner() const { return m_inner; } @@ -650,7 +650,7 @@ class CastToCommand final : public Node { class CastToList final : public Node { public: CastToList(Position, RefPtr); - virtual ~CastToList(); + virtual ~CastToList() = default; virtual void visit(NodeVisitor& visitor) override { visitor.visit(this); } const RefPtr& inner() const { return m_inner; } @@ -733,7 +733,7 @@ class ContinuationControl final : public Node { , m_kind(kind) { } - virtual ~ContinuationControl() { } + virtual ~ContinuationControl() = default; virtual void visit(NodeVisitor& visitor) override { visitor.visit(this); } ContinuationKind continuation_kind() const { return m_kind; } diff --git a/Userland/Shell/Execution.h b/Userland/Shell/Execution.h index 47c23a3e09b1fb..0437700a308a6c 100644 --- a/Userland/Shell/Execution.h +++ b/Userland/Shell/Execution.h @@ -17,7 +17,7 @@ namespace Shell { class FileDescriptionCollector { public: - FileDescriptionCollector() { } + FileDescriptionCollector() = default; ~FileDescriptionCollector(); void collect(); diff --git a/Userland/Shell/SyntaxHighlighter.cpp b/Userland/Shell/SyntaxHighlighter.cpp index da670e4f842808..619fe2429b845a 100644 --- a/Userland/Shell/SyntaxHighlighter.cpp +++ b/Userland/Shell/SyntaxHighlighter.cpp @@ -581,8 +581,4 @@ bool SyntaxHighlighter::token_types_equal(u64 token0, u64 token1) const return token0 == token1; } -SyntaxHighlighter::~SyntaxHighlighter() -{ -} - } diff --git a/Userland/Shell/SyntaxHighlighter.h b/Userland/Shell/SyntaxHighlighter.h index 5cc860cf4d0114..b2c7e22510def5 100644 --- a/Userland/Shell/SyntaxHighlighter.h +++ b/Userland/Shell/SyntaxHighlighter.h @@ -12,8 +12,8 @@ namespace Shell { class SyntaxHighlighter : public Syntax::Highlighter { public: - SyntaxHighlighter() { } - virtual ~SyntaxHighlighter() override; + SyntaxHighlighter() = default; + virtual ~SyntaxHighlighter() override = default; virtual bool is_identifier(u64) const override; virtual bool is_navigatable(u64) const override;