Loop over 'vars' in prep_mortality_damages() is unused?

[davidrzhdu]

dscim/src/dscim/preprocessing/input_damages.py

Line 694 in 3d1242b

for var, name in vars.items():

This loop seems to be a leftover from the old version of dscim.preprocessing.input_damages.prep_mortality_damages() and is unused here. Related to that, prep() in line 702 takes name as an arg, but it is unused.

dscim/src/dscim/preprocessing/input_damages.py

Lines 696 to 703 in 3d1242b

	def prep(
	ds,
	gcm=gcm,
	scaling_deaths=scaling_deaths,
	scaling_costs=scaling_costs,
	valuation=valuation,
	name=name,
	):

[davidrzhdu]

We might also want to fix the file name when saving the output (e.g., f"outpath/impacts-darwin-montecarlo-damages-v{mortality_version}.zarr")

dscim/src/dscim/preprocessing/input_damages.py

Lines 747 to 758 in 3d1242b

	if i == 0:
	damages.to_zarr(
	outpath,
	consolidated=True,
	mode="w",
	)
	else:
	damages.to_zarr(
	outpath,
	consolidated=True,
	append_dim="gcm",
	)

[JMGilbert]

Fixed in 5ebe7de.