Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mismatched order of region creates chunk issue #80

Closed
davidrzhdu opened this issue Mar 30, 2023 · 1 comment
Closed

Mismatched order of region creates chunk issue #80

davidrzhdu opened this issue Mar 30, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@davidrzhdu
Copy link
Contributor

dscim/src/dscim/preprocessing/input_damages.py

Line 211 in 8df2c44

concat_ds[v] = (concat_ds[v] / ec_cls.econ_vars.pop) * -1 * conversion_value

Labor damages and EconVars have different orders of region, which creates some chunk issues.
@davidrzhdu davidrzhdu added the bug Something isn't working label Mar 30, 2023
@davidrzhdu
Copy link
Contributor Author

This gets resolved in 45d3397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

80-mismatched-order-of-region-creates-chunk-issue ClimateImpactLab/dscim
2 participants
@kemccusker @davidrzhdu