Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated xarray method .drop with .drop_sel in simple_storage #37

Closed
brews opened this issue Sep 15, 2022 · 1 comment · Fixed by #54
Closed

Replace deprecated xarray method .drop with .drop_sel in simple_storage #37

brews opened this issue Sep 15, 2022 · 1 comment · Fixed by #54
Assignees
@brews
Labels
bug Something isn't working

Comments

@brews
Copy link
Member

brews commented Sep 15, 2022

dscim/src/dscim/menu/simple_storage.py

Line 134 in 8a870c3

anomaly = anomaly.drop(

xarray docs say that .drop is deprecated in favor of .drop_sel or other .drop_*s.
@brews brews added the bug Something isn't working label Sep 15, 2022
@brews brews changed the title Replace deprecated xarray method .drop with .drop_sel Replace deprecated xarray method .drop with .drop_sel in simple_storage Sep 16, 2022
@brews
Copy link
Member Author

brews commented Sep 28, 2022

Thought: We might need to update the minimum version allowed for xarray with this update.

@brews brews self-assigned this Sep 28, 2022
@brews brews mentioned this issue Sep 28, 2022
Merged
@brews brews closed this as completed in #54 Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brews brews

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix xarray .drop() deprecation ClimateImpactLab/dscim
1 participant
@brews