Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad args to path.replace() will raise TypeError in preprocessing.clip_damages() #36

Closed
brews opened this issue Sep 15, 2022 · 0 comments · Fixed by #55
Closed

Bad args to path.replace() will raise TypeError in preprocessing.clip_damages() #36

brews opened this issue Sep 15, 2022 · 0 comments · Fixed by #55
Assignees
Labels
bug Something isn't working

Comments

@brews
Copy link
Member

brews commented Sep 15, 2022

This line calls the replace method to a pathlib.Path-like with two args. This would work if it was a str -- which it might have been in the past -- unfortunately Path.replace() takes a single arg as input. So I think this will raise a TypeError if it's ever run.

outpath = path.replace(".zarr", "_clipped.zarr")

@brews brews added the bug Something isn't working label Sep 15, 2022
@brews brews self-assigned this Sep 28, 2022
@brews brews closed this as completed in #55 Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant