MainRecipe.global_consumption_calculation missing first parameter "self"

[brews]

MainRecipe.global_consumption_calculation() looks like it should have self as its first argument but it's first arg is "disc_type", without self. I'm not sure what's the intent here.

dscim/src/dscim/menu/main_recipe.py

Line 771 in 8a870c3

def global_consumption_calculation(disc_type):

[brews]

Yeah, it looks like self should be there, given how args are later passed in to the method here

dscim/src/dscim/menu/main_recipe.py

Line 788 in 8a870c3

array_pc = self.global_consumption_calculation(

This is a bug.

[kemccusker]

@brews how did that code run without this fix? That's confusing.

[brews]

@kemccusker In this case, it was an abstract method — like a placeholder outlining things to overload later — it didn't actually have code to run itself. It was just signaling the intent inconsistently.