Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"mean_dims" in calculate_constant_equivalent_discount_rate has a mutable default arg #26

Closed
brews opened this issue Sep 15, 2022 · 0 comments
Closed

"mean_dims" in calculate_constant_equivalent_discount_rate has a mutable default arg #26

brews opened this issue Sep 15, 2022 · 0 comments
Assignees
@brews
Labels
bug Something isn't working

Comments

@brews
Copy link
Member

brews commented Sep 15, 2022

dscim.utils.functions.calculate_constant_equivalent_discount_rate's "mean_dim" is a mutable default argument.

This is a common gotcha, we might want to refactor this to avoid bugs.

dscim/src/dscim/utils/functions.py

Line 64 in 8a870c3

def calculate_constant_equivalent_discount_rate(

@brews brews added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Sep 15, 2022
@brews brews self-assigned this Sep 16, 2022
@brews brews removed good first issue Good for newcomers help wanted Extra attention is needed labels Sep 16, 2022
@brews brews closed this as completed in cbdfbab Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brews brews

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brews