-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
float32 vs float64 difference issues #11
Comments
Hey @JMGilbert. When you have a second, I was curious: In the change you're pointing to in 4adfb60, explicitly casting Just feeling this out without making dramatic changes: An alternative might be to replace those key calls to If I wanted to test to see if this or another solution works, what would I need to run? How to replicate the original problem you had? You had to test this on two different machines, as I recall...? This wasn't something that the tests in |
This commit introduces a change that allows for consistent replication between machines, but changes the values of SCCs relative to their prior values. Without this chunk of code, different machines give different results for powers of coefficients, which leads to larger differences in SCCs. This may be related to the fact that
np.longdouble
returnsnp.float128
on one machine, andnp.longdouble
on another. Some kind of changes probably need to be considered to ensure that SCCs run consistently between machines and can be replicated from prior results.The text was updated successfully, but these errors were encountered: