Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated xarray breaks dscim #103

Closed
brews opened this issue Jul 17, 2023 · 2 comments · Fixed by #129
Closed

Updated xarray breaks dscim #103

brews opened this issue Jul 17, 2023 · 2 comments · Fixed by #129
Assignees
Labels
bug Something isn't working

Comments

@brews
Copy link
Member

brews commented Jul 17, 2023

Dependabot tried to bump xarray 2022.11.0 to 2023.7.0 in #101 and it failed tests in CI.

Here are the archived logs from that CI run in case the link expires: logs_381.zip

I haven't dug through this but should fix the package so it can run on the latest versions of xarray.

@brews brews added the bug Something isn't working label Jul 17, 2023
@brews
Copy link
Member Author

brews commented Aug 11, 2023

This is partly because binary operations respect keep_attrs as of xarray v2023.2.0 (see pydata/xarray#7391)

This means that the binary operation to calculate the anomaly here can cause later problems when the anomaly shares attrs keys with data it will be combined with here.

Keeping old behavior means ditching attrs during those binary operations, but maybe we should consider how xr.combine_by_coords handles attrs between the data it's combining. ...So, set something sensible for combine_attrs.

@brews
Copy link
Member Author

brews commented Aug 11, 2023

Another problem seems to be that as of xarray v2023.3.0 bool arrays used for indexing can't be dask-backed. They need to be computed and in memory so their size can be comprehended.

This is a problem in lines like this.

@brews brews self-assigned this Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant