Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance monitoring #329

Closed
juliushaertl opened this issue Jul 8, 2021 · 3 comments · Fixed by #496
Closed

Performance monitoring #329

juliushaertl opened this issue Jul 8, 2021 · 3 comments · Fixed by #496
Labels
1. to develop enhancement

Comments

@juliushaertl
Copy link
Contributor

Feature Request

Besides error tracking, Sentry also offers performance monitoring capabilities https://docs.sentry.io/product/performance/

Summary

It would probably be interesting to see this can also be used to trace performance metrics of certain operations like db transactions, controller execution or app bootstrap for example. It would also be available for the frontend where it could even gather web vitals metrics.

https://docs.sentry.io/platforms/php/performance/
https://docs.sentry.io/platforms/javascript/performance/
https://docs.sentry.io/product/performance/web-vitals/

We might be able to use or extend the already existing OCP\Diagnostics\IEventLogger for that in the server https://github.com/nextcloud/server/blob/215aef3cbdc1963be1bb6bca5218ee0a4b7f1665/lib/public/Diagnostics/IEventLogger.php#L31
@juliushaertl juliushaertl mentioned this issue May 10, 2022
Closed
2 tasks
@ChristophWurst
Copy link
Owner

ChristophWurst commented Jan 23, 2023 •
edited
Loading

With nextcloud/server#36310 we should be able to register a middleware that runs around every request and monitors controller methods as transactions 🍿

@ChristophWurst ChristophWurst mentioned this issue Jan 23, 2023
Merged
6 tasks
@ChristophWurst
Copy link
Owner

Tada

Bildschirmfoto vom 2023-01-24 09-29-59

@ChristophWurst ChristophWurst mentioned this issue Jan 24, 2023
Merged
1 task
@skjnldsv
Copy link

Yesss!!!
Can't wait to see where we lose so much perfs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(performance): Add performance monitoring ChristophWurst/nextcloud_sentry
3 participants
@ChristophWurst @juliushaertl @skjnldsv