-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: python refactor #65
Comments
thanks @jxdv , feel free to do the PRs , although expect some delays on their review, since I am out of office. |
Closing this since I've already opened up some cleanup PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, first of all thanks for this tool. I was reading the code, and noticed there's some room for improvements.
Few examples:
The above function could be rewritten for easier readability like this:
Class parenthesis are redundant in python3, and since medusa doesn't support python2 they are no longer needed:
The parenthesis here are also redundant:
Could just be:
And a lot more..I think it'd be better to have well formatted code that follows the best practices. LMK if you care about this at all, and I can create some PRs.
The text was updated successfully, but these errors were encountered: